Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to mark files in a PR as viewed #19007

Merged
merged 60 commits into from
May 7, 2022
Merged

Allow to mark files in a PR as viewed #19007

merged 60 commits into from
May 7, 2022

Conversation

delvh
Copy link
Member

@delvh delvh commented Mar 5, 2022

Users can now mark files in PRs as viewed, resulting in them not being shown again by default when they reopen the PR again.

Additionally, I added a Changed since last review label if the file has been changed by a newer commit than the one the PR was reviewed with (see video example below).

2022-03-05.01-06-20.mp4

Fixes #11730

@delvh delvh added this to the 1.17.0 milestone Mar 5, 2022
@delvh delvh added type/feature Completely new functionality. Can only be merged if feature freeze is not active. kind/usability topic/ui-interaction Change the process how users use Gitea instead of the visual appearance topic/pr Issues related to pull requests labels Mar 5, 2022
@delvh delvh mentioned this pull request Mar 5, 2022
@codecov-commenter

This comment was marked as outdated.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 5, 2022
models/pull_review.go Outdated Show resolved Hide resolved
models/pull_review.go Outdated Show resolved Hide resolved
models/pull_review.go Outdated Show resolved Hide resolved
@delvh

This comment was marked as outdated.

models/migrations/v214.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 7, 2022
@6543
Copy link
Member

6543 commented May 7, 2022

testing ....wip

Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 7, 2022
@6543 6543 merged commit 5ca224a into go-gitea:main May 7, 2022
@delvh
Copy link
Member Author

delvh commented May 7, 2022

@lunny should the model in models/pull/review_state be updated as well?
Or does that not have an impact because the database schema is already correct?

@delvh delvh deleted the viewed-files branch May 7, 2022 19:02
@6543
Copy link
Member

6543 commented May 7, 2022

@delvh did address it for you: 18c4913

6543 added a commit to 6543-forks/gitea that referenced this pull request May 7, 2022
@delvh delvh mentioned this pull request May 7, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 8, 2022
* giteaofficial/main:
  Delete related PullAutoMerge and ReviewState on User/Repo Deletion (go-gitea#19649)
  Allow custom default merge message with .gitea/default_merge_message/<merge_style>_TEMPLATE.md (go-gitea#18177)
  Allow to mark files in a PR as viewed (go-gitea#19007)
  Auto merge pull requests when all checks succeeded via API (go-gitea#9307)
  Hide private repositories in packages (go-gitea#19584)
  Only show accessible teams in dashboard dropdown list (go-gitea#19642)
  prevent double click new issue/pull/comment button (go-gitea#16157)
  Improve reviewing PR UX (go-gitea#19612)
  [skip ci] Updated translations via Crowdin
  Add Changelog v1.16.7 (go-gitea#19575) (go-gitea#19644)
  Set safe dir for git operations in .drone.yml CI (go-gitea#19641)
  Add missing `sorting` column in `project_issue` table (go-gitea#19635)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
Users can now mark files in PRs as viewed, resulting in them not being shown again by default when they reopen the PR again.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/pr Issues related to pull requests topic/ui-interaction Change the process how users use Gitea instead of the visual appearance type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "Viewed" option in Pull Requests
10 participants